Skip to content

Commit

Permalink
Why does this fail on Ubuntu?
Browse files Browse the repository at this point in the history
  • Loading branch information
badeball committed Sep 28, 2024
1 parent 80226ec commit 98ec18b
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 242 deletions.
54 changes: 2 additions & 52 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,14 @@ concurrency:
cancel-in-progress: true

jobs:
prepare-versions:
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- name: Checkout
uses: actions/checkout@v4
- id: set-matrix
name: Prepare
run: echo "matrix=$(node -p "JSON.stringify(require('./package.json').peerDependencies['cypress'].split(' || '))")" >> $GITHUB_OUTPUT
- run: npm -v

test:
needs: prepare-versions
runs-on: ubuntu-latest
container:
image: cypress/browsers:latest
strategy:
fail-fast: false
matrix:
cypress-version: ${{fromJson(needs.prepare-versions.outputs.matrix)}}
cypress-version: ["13"]
steps:
- uses: actions/setup-node@v4
with:
Expand Down Expand Up @@ -56,44 +43,7 @@ jobs:
- name: Build
run: npm run build
- name: Test
run: npm run test
- name: Versions
run: |
npx cypress --version
node --version
npm --version
windows:
runs-on: windows-latest
env:
NPM_CONFIG_CACHE: ${{ github.workspace }}/.npm
CYPRESS_CACHE_FOLDER: ${{ github.workspace }}/.cypress
steps:
- uses: actions/setup-node@v4
with:
node-version: 18
- name: Checkout
uses: actions/checkout@v4
- name: Cache NPM modules
uses: actions/cache@v4
with:
path: .npm
key: npm-windows
- name: Cache Cypress binaries
uses: actions/cache@v4
with:
path: .cypress
key: cypress-windows
- name: Dependencies
shell: bash
run: npm install --engine-strict
- name: Build
run: npm run build
# https://github.com/webpack/webpack/issues/12759
- name: Remove Webpack test
run: rm features/loaders/webpack.feature
- name: Test
run: npm run test:integration
run: npm run test:integration -- features/reporters/usage.feature:91
- name: Versions
run: |
npx cypress --version
Expand Down
118 changes: 0 additions & 118 deletions .github/workflows/examples-branch.yml

This file was deleted.

72 changes: 0 additions & 72 deletions .github/workflows/examples-master.yml

This file was deleted.

12 changes: 12 additions & 0 deletions lib/subpath-entrypoints/esbuild.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ export function createEsbuildPlugin(
const needPrettify =
lastSource != null && !(await isRelativeToProjectRoot(lastSource));

debug("last source", lastSource);
debug("project root", configuration.projectRoot);
debug(
"isRelativeToProjectRoot",
await isRelativeToProjectRoot(lastSource),
);
debug("sources before (all)", sourceMap.sources);
debug("sources before (last)", sourceMap.sources.slice(-5));

/**
* There are numerous issues regarding the sources property in esbuild, particularly when
* different drives are involved (which is the case on Github actions, when using
Expand Down Expand Up @@ -80,6 +89,9 @@ export function createEsbuildPlugin(
debug("esbuild: using original sources");
}

debug("sources after (all)", sourceMap.sources);
debug("sources after (last)", sourceMap.sources.slice(-5));

await fs.rm(sourceMapLocation);

const encoded = Buffer.from(JSON.stringify(sourceMap)).toString(
Expand Down

0 comments on commit 98ec18b

Please sign in to comment.