Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afterRunHandler ndjson to json #724

Closed
adamzoltan873 opened this issue Jun 1, 2022 · 1 comment
Closed

afterRunHandler ndjson to json #724

adamzoltan873 opened this issue Jun 1, 2022 · 1 comment

Comments

@adamzoltan873
Copy link

Hi @badeball,

In

if (!preprocessor.messages.enabled) {

you are referencing the messages.enabled config property, for creating the json output.

I also faced the problem with windows and cucmber-json-formatter (#708)
With omitting the afterRunHandler, now I have the opportunity to skip the ndjson -> json conversion, but as I can see the referenced line should be the following

if (!preprocessor.json.enabled) {

beacuse if I enable messages in config I will get the ndjson file, but if I disable json in config, the condition will met, and will still get a converted json file.

Thanks, adamzoltan

badeball added a commit that referenced this issue Jun 15, 2022
badeball added a commit that referenced this issue Jun 15, 2022
badeball added a commit that referenced this issue Jun 15, 2022
@badeball
Copy link
Owner

Hey, @adamzoltan873, thanks for reporting the issue. I've fixed this in v11.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants