-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badge request: GitHub actions #2574
Comments
Some questions for you:
|
|
Here is an example: https://github.com/CultureHQ/github-actions-badge |
@devblackops I'm using the badge from @kddeisz and it works great, they added functionality to link to github action results as well, maybe that can be added to |
using https://github.com/CultureHQ/github-actions-badge until badges/shields#2574 or something from GitHub is ready
using https://github.com/CultureHQ/github-actions-badge until badges/shields#2574 or something from GitHub is ready
+1 |
It looks like the other example posted is calling a URL like https://api.github.com/repos/badges/shields/commits/master/check-suites with the header
..and then looking for a check-suite with the name "GitHub Actions". GitHub's docs on this API call say
( see https://developer.github.com/v3/checks/suites/#list-check-suites-for-a-specific-ref ) but tbh, if someone's interested in working on this, I'd be inclined to take a PR for it even though the API is beta at this stage. |
FYI official badge api https://github.com/{github_id}/{repository}/workflows/{workflow_name}/badge.svg |
How interesting.. https://github.com/actions/toolkit/workflows/Main%20workflow/badge.svg Do you have a link to the docs for that, or do you have to be in the actions beta to see them? I'd be interested to read more about this. |
Found it at reddit -> https://www.reddit.com/r/github/comments/csehoc/github_actions_official_status_badges/ |
I wonder if we went the SvgScraping route if we'd be able to avoid having to use tokens from the pool/hitting the throttling limits 🤔 |
Based on my testing, the workflow should be on the main branch for the badge to be generated. How about you? |
@khakiout - I believe that is true based on what I've seen |
I've opened #3898 and #3913 with two different implementations we could consider using. However, my takeaway from working on these is that any support we may potentially add for GitHub Actions to Shields in the short term would inevitably have some limitations and wouldn't be able to support certain edge cases. At this moment GH Actions are still pretty new/beta, and there's just not a good official/well documented approach for Shields to get the GH Actions data, so we're stuck using the undocumented/unofficial or indirect approaches. |
Also if anyone is using GitHub Actions in your repos and is willing to test... Try out your repo/workflow in the staging apps:
|
@calebcartwright Works fine for me on WindowsSpyBlocker 👌 |
@calebcartwright Works fine for me, too. 👍 |
There are doubts that this functionality works as it should. At the moment, all the links on the Do you have exactly the same? |
It works for me, look at the CI badges in my project: https://github.com/knocte/geewallet |
@knocte Yes, it’s working now. Maybe it was just a temporary problem. Thx 👍 |
Does anyone know whether or not this works on private repos? |
Hi Folks - just a friendly reminder that if you have questions about GitHub's native badge for GitHub Actions/Workflows, you should probably use a different channel to pose those questions. I'd suggest going to one of the GitHub forums to try to get an answer directly from GitHub. This thread is getting really long, with a lot of non-Shields related comments. Would like to try keep this thread focused on the OT of Shields.io support for GH Actions badges. Thanks! |
Given the case-sensitive workflow names: It would be nice, if the actions badge implementation accepted an optional query parameter (@calebcartwright BTW: When an issue gets OT comments like the ones above, you can hide them by clicking on the "Hide" in the |
This is supported on all Shields badges, and will also be available for Shields badges for GH Actions
Thanks @svoop, I'm aware of this but deliberately left them as-is since they contain information folks may find useful outside the Shields context. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@calebcartwright Jeez, me, always one step behind 😄 Thanks for the hint! |
no worries! |
Closed via #3898 |
This feature has been implemented is now live! Thanks to @paulmelnikow for getting it shipped so quickly after the PR was merged🎉 Some examples: And one with all sorts of Shields-customization goodness There's another issue open to track the work for implenting Job-level status badges in #4364 if anyone is interested in tracking that work (or implementing! ❤️) |
Official Tweet about this new badge: https://twitter.com/Shields_io/status/1200540112368611328 Like and retweet to give us more visibility! 😉 |
I cant get this to work https://github.com/bus-stop/x-terminal/workflows/main/badge.svg Seems all valid and based on format shared? |
Ah, the https://img.shields.io/github/workflow/status/bus-stop/x-terminal/CI |
📋 Description
badges for github actions
🔗 Data
Being consulted, this is just an idea. No API available now.
https://developer.github.com/actions/
The text was updated successfully, but these errors were encountered: