Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [Instagram] badge #4348

Closed
wants to merge 2 commits into from
Closed

Add [Instagram] badge #4348

wants to merge 2 commits into from
+100 −0

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Nov 16, 2019

See #2120.

@PyvesB PyvesB added the service-badge New or updated service badge label Nov 16, 2019
@shields-ci
Copy link

shields-ci commented Nov 16, 2019 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 3b201b3

@shields-cd shields-cd temporarily deployed to shields-staging-pr-4348 November 16, 2019 10:40 Inactive
@PyvesB
Copy link
Member Author

PyvesB commented Nov 16, 2019

Result on the review app:

calebcartwright
calebcartwright previously approved these changes Nov 16, 2019
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One inline, non-blocking, thought on potentially using a helper in the schema.

@PyvesB PyvesB added the on-hold Deferred in favor of another approach, blocked on preceding efforts, stale, or abandoned label Nov 16, 2019
@PyvesB
Copy link
Member Author

PyvesB commented Nov 16, 2019 •
edited
Loading

Do not merge, we've got a rate-limiting problem which I've documented on the linked issue:
#2120 (comment)

@PyvesB PyvesB closed this Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright

Assignees
No one assigned
Labels
on-hold Deferred in favor of another approach, blocked on preceding efforts, stale, or abandoned service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PyvesB @shields-ci @calebcartwright @shields-cd