Fix and enhance download.py #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed to add Accept: application/xml to the headers as the Jamf Pro server now serves up json by default. I had originally put in content-type: application/xml but I suppose that would only apply to uploads... I removed line 70 that contained a print statement that would cause the script to error if you have EAs without scripts. I was checking for the condition but if it matched the print would cause a failure. I added some light error handling on the first request to the Jamf Pro server. I also added some logic to prompt for a password if you omit the --password argument.
Bringing the tools copy up to speed with the last few commits
Removed the line that stated it would be removed from the root of the project in a future release as this is the new location.
|
Awesome, thanks for the work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches will fix the issue where json is now delivered by default and you have EAs without scripts. It includes an option to prompt for password if one is omitted on the command line and some very basic error handling of the first call to the Jamf Pro Server.