gitignore file, stricter shebang matching, updated read me #27
Conversation
This eliminates potential false positives for scripts that contain other scripts of a different type (e.g. python scripts stored in bash "here documents").
| *.pyc | ||
|
|
||
| # Example scripts and EAs | ||
| extension_attributes/* |
There was a problem hiding this comment.
@homebysix This still allows tracking of sub folders, correct? Is the idea that this line will keep errant files from being tracked within extension_attributes and scripts?
There was a problem hiding this comment.
Yes — line 10 excludes extension attributes, but line 11 re-includes the example EAs in the repo. Same for the scripts in lines 12-13.
This change is primarily for the benefit of those who want to contribute to the development of git2jss without having to manually remove downloaded scripts and extension attributes from the repo before committing/pushing.
Alternatively, I thought the ability to specify an alternate destination for the extension attributes and scripts would be a nice feature-add, but didn't have time yet to implement it.
|
I like this for my personal dev purposes, it might cause confusion for people that are forking the project to their internal repos and then doing a |
|
If people are forking the project to their internal repos, they'll already need to know how to handle multiple remotes in order to continue getting the latest changes from upstream. Would it be better to add the ability to download extension attributes and scripts to a location outside the repo? If so, I can work on that. |
|
I can agree with that first statement, I think long term Brad and I have both tossed around the idea of specifying an alternative location for scripts but I don't think we need to hold this PR up for it. |
No description provided.