Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility check and testing for Responsive Design (jsonConfig) #123

Closed
ioBroker-Bot opened this issue Oct 15, 2024 · 3 comments
Closed

Comments

@ioBroker-Bot
Copy link

Notification from ioBroker Check and Service Bot

Dear Adapter developer,

ioBroker should be fully usable and operable on mobile devices

So please check your adapter jsonConfig for Responsive Design.
You can perform these tests in the developer console of your browser (F12)


For jsonConfig, all resolutions should be taken into account in the respective inputs.

The following resolutions are provided:

  • xl - width in 1/12 of screen on extra large screens (1536px < width)
  • lg - width in 1/12 of screen on large screens (1200px <= width < 1536px)
  • md - width in 1/12 of screen on middle screens (900px <= width < 1200px)
  • sm - width in 1/12 of screen on small screen (600px <= width < 900px)
  • xs - width in 1/12 of screen on tiny screens (width < 600px)

We recommend the following values for the standard layout

"xs": 12,
"sm": 12,
"md": 6,
"lg": 4,
"xl": 4

The following entry should be made below "type": "tabs" in order to display a clearly legible table bar:

"tabsStyle": {
  width: "calc(100% - 100px)"
},

Please close the issue after you checked it.

Feel free to contact me (@ioBroker-Bot) if you have any questions.

And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.

your
ioBroker Check and Service Bot

@simatec for evidence

Note: If you added Responsive Design tests already, simply close this issue.

baerengraben pushed a commit that referenced this issue Oct 29, 2024
baerengraben pushed a commit that referenced this issue Oct 29, 2024
* (baerengraben) Fix for #124
* (baerengraben) Fix for #123
* (baerengraben) Fix for #122
* (baerengraben) Fix for #121
@baerengraben
Copy link
Owner

Fixed with v2.1.1

@simatec
Copy link

simatec commented Oct 30, 2024

There is an error for the tabstyle in your jsonConfig.

"tabsStyle": {
    width: "calc(100% - 100px)"
  },

Since you are not using json5, you must write width with inverted commas.

This is how it should look:

"tabsStyle": {
    "width": "calc(100% - 100px)"
  },

@baerengraben
Copy link
Owner

Oh, ok. Thank you for the hint!

baerengraben pushed a commit that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants