Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

上游docparser中return_raw误传Fasle抛异常提醒 #371

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

Super-BJUT
Copy link
Contributor

No description provided.

@@ -75,6 +75,9 @@ def run(self, message: Message):
if not self.splitter_type:
raise ValueError("splitter_type must be a value")

if not parse_result.raw:
raise ValueError("ParseResult must contain the attribute of raw, maybe the value of return_raw is not True")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的报错不易读,建议更改下,用三段式:1、报错是什么;2、期望的配置设置是什么;3、现在的错误配置是什么

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@MrChengmo MrChengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrChengmo MrChengmo merged commit 7c4cd04 into baidubce:master Jun 27, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants