Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish pre-release docs for PRs & main branch #339

Merged
merged 30 commits into from
Aug 28, 2023
Merged

Publish pre-release docs for PRs & main branch #339

merged 30 commits into from
Aug 28, 2023

Conversation

raminqaf
Copy link
Contributor

@raminqaf raminqaf commented Aug 23, 2023 •
edited
Loading

Fixes #141

@raminqaf raminqaf added area/documentation Improvements or additions to documentation area/CI Relates to GitHub actions labels Aug 23, 2023
@raminqaf raminqaf self-assigned this Aug 23, 2023
@raminqaf raminqaf marked this pull request as ready for review August 23, 2023 15:03
@sujuka99
Copy link
Contributor

Did you test it somehow?

disrupted
disrupted requested changes Aug 23, 2023
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/actions/update-docs/action.yml Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted August 24, 2023 08:55
@raminqaf raminqaf requested a review from disrupted August 24, 2023 12:10
disrupted
disrupted requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the PR title

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/actions/update-docs/action.yml Outdated Show resolved Hide resolved
.github/actions/update-docs/action.yml Outdated Show resolved Hide resolved
@raminqaf raminqaf changed the title Build dev of docs on pull requests Build docs dev version on PRs & create doc main branch version Aug 25, 2023
@raminqaf
Copy link
Contributor Author

please update the PR title

Done

@raminqaf raminqaf requested a review from disrupted August 28, 2023 07:19
@disrupted disrupted changed the title Build docs dev version on PRs & create doc main branch version Publish pre-release docs for PRs & main branch Aug 28, 2023
disrupted
disrupted requested changes Aug 28, 2023
View reviewed changes
.github/actions/update-docs/action.yml Outdated Show resolved Hide resolved
.github/actions/update-docs/action.yml Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted August 28, 2023 07:50
@raminqaf raminqaf merged commit cd58390 into main Aug 28, 2023
@raminqaf raminqaf deleted the docs/build-dev branch August 28, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@sujuka99 sujuka99 Awaiting requested review from sujuka99

@irux irux Awaiting requested review from irux

Assignees

@raminqaf raminqaf

Labels
area/CI Relates to GitHub actions area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push changes in documentation to https://bakdata.github.io/kpops/dev/ on push to main
3 participants
@raminqaf @sujuka99 @disrupted