Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment preparation: Protocol Fee Controller migration #189

Open
wants to merge 6 commits into
base: deployment-preparation/protocol-fee-controller-v2
Choose a base branch
from

Conversation

EndymionJkb
Copy link
Collaborator

Deployment preparation: Protocol Fee Controller migration

Don't have a final commit; this is based off the protocol fee controller v2 deployment prep (unmerged). Just stacking them like this to get a full end-to-end to ensure everything will work.

This will need to be adjusted after merging the protocol fee controller task, so that the new fee controller can be deployed separately and passed in. Here, it is deployed along with the migrator, so that the fork test will work.

Deployment preparation tasks checklist:

  • Deployments README is updated with the new task name and link
  • Task README has a description and links to the artifacts
  • build-info is updated with artifacts compiled at the specified commit
  • Artifacts are generated from build-info
  • New task has a working fork test

Code checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented in tests and scripts
  • Fork test block number and test cases are appropriate for this deployment
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant