Authorizer: Refactor implementation #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
force-pushed
the
authorizer/refactor
branch
from
774a3bb to
43afa56
Compare
facuspagnuolo
force-pushed
the
authorizer/refactor
branch
from
43afa56 to
e3cf847
Compare
facuspagnuolo
changed the title
facuspagnuolo
force-pushed
the
authorizer/refactor
branch
from
dec7d87 to
818b46a
Compare
facuspagnuolo
force-pushed
the
authorizer/refactor
branch
from
818b46a to
82d7c8b
Compare
nventuro
reviewed
Feb 4, 2022
facuspagnuolo
force-pushed
the
authorizer/refactor
branch
from
63c9c8b to
73011c4
Compare
nventuro
approved these changes
Feb 7, 2022
facuspagnuolo
force-pushed
the
authorizer/refactor
branch
from
73011c4 to
e799f02
Compare
…cer-core-v2 into authorizer/refactor
dandagow3t
pushed a commit
to IlluviumGame/balancer-v2-monorepo
that referenced
this pull request
May 10, 2023
* authorizer: refactor and improve tests * authorizer: refactor implementation * authorizer: add admin tests * authorizer: address feedback from @nventuro * authorizer: fix swap tests * authorizer: fix tests * authorizer: fix gauges tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #985
This PR introduces a simplification for the authorizer implementation. Mainly what was proposed in #985 to rename "roles" to "permissions". Additionally, I propose a different way of implementing the idea of an admin using the authorizer itself.