-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to replace serials and missing refs #88
Conversation
3b6449b
to
57f909c
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
fde5c2d
to
eb21ca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add these behind an opts
object for abstractSqlToTypescriptTypes
so that it is possible to tailor the generated output based on the use case, because there are definitely use cases where keeping the field references as type references makes sense (any case where we aren't subsetting the model imo)
5056366
to
9e1b6bb
Compare
@Page- Made some changes that I think get this PR a bit closer. If we do in fact want to keep two separate options I'll split them out into two separate commits. |
9e1b6bb
to
206e29c
Compare
Add new options to replace Serial/Big Serial typed fields and instead return them as Integer. And another option to replace missing references with the references datatype. Change-type: minor
206e29c
to
e274475
Compare
Split this work into: |
Add new options to replace Serial/Big Serial typed
fields and instead return them as Integer. And another
option to replace missing references with the references
datatype.
Change-type: minor