Migrate Rendition Buttons to MUI Buttons #63
Conversation
JSReds
force-pushed
the
migrate-buttons
branch
from
66a9831 to
e0b7007
Compare
src/AutoUI/Lenses/LensSelection.tsx
Outdated
| <ToggleButton | ||
| key={item.slug} | ||
| value={item.slug} | ||
| data-test={`lens-selector--${item.slug}`} |
There was a problem hiding this comment.
I see it's related to our e2e tests, but wondering if there's anything else to the property/property name or if it's just something we made for our e2e
There was a problem hiding this comment.
this is just for our e2e tests, using the data- attribute https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/data-*
| const HeaderGrid = styled(Flex)` | ||
| row-gap: 8px; |
There was a problem hiding this comment.
Noting for later: We need to do the Flex/Box/Grid migration here as well, this looks like a spot that would use Grid
JSReds
force-pushed
the
migrate-buttons
branch
from
e0b7007 to
acbb345
Compare
JSReds
force-pushed
the
migrate-buttons
branch
2 times, most recently
from
30e14bd to
8cf9252
Compare
| @@ -0,0 +1,54 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
Renamed to temporarly disable specs as jest is not happy with ui-shared-components build. Speaking about it we will probably remove jest and add playwright
src/AutoUI/index.tsx
Outdated
| } from "../oData/jsonToOData"; | ||
| import { CollectionLensRendererProps } from "./Lenses/types"; | ||
| import pickBy from "lodash/pickBy"; | ||
| import { NoRecordsFoundView } from "./NoRecordsFoundView"; |
There was a problem hiding this comment.
What happened with the formatting on all these imports? 😕 They should all be single quotes I believe...
Change-type: patch
JSReds
force-pushed
the
migrate-buttons
branch
from
8cf9252 to
71b3256
Compare
Change-type: patch
JSReds
force-pushed
the
migrate-buttons
branch
from
71b3256 to
0d20701
Compare
Change-type: patch
Depends-on: balena-io-modules/ui-shared-components#46