Request access to previously pushed release via `balena deploy` #1057

xginn8 · 2018-12-28T15:50:31Z

This access is used to cross mount the old layers, rather than
reuploading the layers each time.

Connects-to: #1045
Change-type: minor
Signed-off-by: Matthew McGinn [email protected]

Affects the development, build or deployment processes of the component

pcarranzav · 2018-12-28T23:13:46Z

lib/utils/compose.coffee

+		repos = []
+		for i in images
+			imageName = i.image[0].is_stored_at__image_location
+			[ _, _, repoName, _ = 'latest' ] = /(.*?)\/(.*?)(?::([^/]*))?$/.exec(imageName)


Might be better to use a tighter regex, as in https://github.com/balena-io-modules/docker-toolbelt/blob/master/lib/docker-toolbelt.coffee#L338 (you could even use that docker-toolbelt module)

Admittedly I stole this regex from https://github.com/balena-io/balena-cli/blob/master/lib/utils/compose.coffee#L338, but I think making use of docker-toolbelt sounds like a much better long-term plan. Will update that, thank you!

xginn8 · 2019-01-01T22:43:30Z

I've restructured this PR to use docker-toolbelt and a Promise.map rather than a for loop, PTAL!

xginn8 · 2019-01-02T14:35:02Z

I believe the build failures in travis are related to #1059

xginn8 · 2019-01-04T14:14:17Z

@pdcastro or @thgreasi, mind taking a look at this PR? I'm relatively new to promises and would love a second look.

pdcastro

I am requesting some changes but don't assume that my requests are particularly wise! :-)

lib/utils/compose.coffee

pdcastro · 2019-01-05T00:35:41Z

lib/utils/compose.coffee

+
+	.then (release) ->
+		# grab all images from the latest release, return all image locations in the registry
+		if release.length > 0


I've probably never called sdk.pine.get() so feel free to ignore this question -- save time and don't even bother answering if you think you know what you are doing. Otherwise, could release be null or undefined? In which case release.length would be a ReferenceError, and the safer Coffeescript expression might be release?.length > 0 which would evaluate to false.

lib/utils/compose.coffee

pdcastro · 2019-01-05T01:59:52Z

I believe the build failures in travis are related to #1059

@xginn8, I was told before that we can/should ignore tests that don't have the REQUIRED label next to them. The travis tests don't have the REQUIRED label, so to my trained brain it's like they don't exist. :-)

lib/utils/compose.coffee

xginn8 · 2019-01-09T14:36:39Z

I am still sorting the case where pushing more than 10 images as part of a docker-compose causes the json to be truncated.

xginn8 · 2019-01-09T21:26:20Z

At Alex's behest I added some hacky workaround to deal with #1070, otherwise this PR is ready to merge if it looks good!

pdcastro

@xginn8, thanks for the changes, it's looking good! Just some tidying up before merging:

There are 9 commits and they are not all individually relevant as checkout points for future contributors to the git repo, so I recommend squashing them. There's a sentence about this in the Commit and PR Guidelines process document -- search it for the word 'squash'. (Typically this becomes relevant in future investigations that try to identify a commit that introduced some change or broke something, and for most PRs I believe this should be a single commit.) I'd squash all of the PR's commits into a single one. There are multiple ways to achieve squashing. I normally use git log to find the commit hash of the commit that precedes all the commits in the PR, then run git rebase -i <that_commit_hash>, then in the editor I select squash for all commits except the first, then edit the commit message. Btw, maybe I'm missing out on a simpler way of doing it...
I see that 2 of the 9 commits are merge commits. We prefer rebasing as it leads to a cleaner linear history. (Conceptually I also find rebasing more intuitive: we want to apply our changes to the origin repository, rather than apply the origin repository to our changes. Rebase should have been the default action taken by git pull when git was designed...) There are multiple ways to achieve rebasing. The command I like best is git pull --rebase origin master, as it combines severals steps into one. The Commit and PR Guidelines process document describes how to do it using 4 separate commands / steps.
So after squashing the commits, please rebase on master.
The PR title spilled into the message box: when pushing via `balena…
... deploy`. I don't really remember how this affects the automatic changes to the CHANGELOG by versionbot, but better edit the title to fit in a single line. Maybe it's just the commit messages that get copied to the CHANGELOG, not the PR title? In any case, please review the PR and commit messages so that they are most useful to customers / contributors who will be reading the CHANGELOG and browsing the PR history.

This access is used to cross mount the old layers, rather than reuploading the layers each time. Connects-to: #1045 Change-type: minor Signed-off-by: Matthew McGinn <[email protected]>

xginn8 · 2019-01-10T13:29:33Z

Rebased all the iterations into one commit, @pdcastro PTAL

…vices Change-type: patch See: https://balena.zulipchat.com/#narrow/stream/403752-channel.2Fsupport-help/topic/balena.20deploy.20too.20many.20requests See: #1057

xginn8 requested review from dfunckt, pdcastro and thgreasi December 28, 2018 15:50

pcarranzav approved these changes Dec 28, 2018

View reviewed changes

pdcastro suggested changes Jan 5, 2019

View reviewed changes

dfunckt reviewed Jan 5, 2019

View reviewed changes

lib/utils/compose.coffee Show resolved Hide resolved

pdcastro suggested changes Jan 10, 2019

View reviewed changes

xginn8 force-pushed the access_old_repos branch from a830ac9 to e5b6a7b Compare January 10, 2019 13:23

xginn8 changed the title ~~Request access to previously pushed release when pushing via \`balena…~~ Request access to previously pushed release via balena deploy Jan 10, 2019

Request access to previously pushed release via balena deploy

a42a1a9

This access is used to cross mount the old layers, rather than reuploading the layers each time. Connects-to: #1045 Change-type: minor Signed-off-by: Matthew McGinn <[email protected]>

xginn8 force-pushed the access_old_repos branch from 06bb4d8 to a42a1a9 Compare January 10, 2019 13:28

pdcastro approved these changes Jan 10, 2019

View reviewed changes

xginn8 merged commit 54e91eb into master Jan 10, 2019

xginn8 deleted the access_old_repos branch January 10, 2019 13:50

pdcastro mentioned this pull request Jan 16, 2019

Improve CLI experience on slow/unreliable networks #671

Closed

dfunckt mentioned this pull request Apr 28, 2020

Improve UX with balena deploy when pushing an identical image #1045

Closed

thgreasi mentioned this pull request Dec 5, 2023

deploy: Fix pushing the images for compositions with more than 70 services #2710

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Request access to previously pushed release via `balena deploy` #1057

Request access to previously pushed release via `balena deploy` #1057

xginn8 commented Dec 28, 2018 •

edited by pdcastro

Loading

pcarranzav Dec 28, 2018

xginn8 Dec 31, 2018

xginn8 commented Jan 1, 2019

xginn8 commented Jan 2, 2019

xginn8 commented Jan 4, 2019

pdcastro left a comment

pdcastro Jan 5, 2019

pdcastro commented Jan 5, 2019

xginn8 commented Jan 9, 2019

xginn8 commented Jan 9, 2019

pdcastro left a comment

xginn8 commented Jan 10, 2019

Request access to previously pushed release via balena deploy #1057

Request access to previously pushed release via balena deploy #1057

Conversation

xginn8 commented Dec 28, 2018 • edited by pdcastro Loading

pcarranzav Dec 28, 2018

Choose a reason for hiding this comment

xginn8 Dec 31, 2018

Choose a reason for hiding this comment

xginn8 commented Jan 1, 2019

xginn8 commented Jan 2, 2019

xginn8 commented Jan 4, 2019

pdcastro left a comment

Choose a reason for hiding this comment

pdcastro Jan 5, 2019

Choose a reason for hiding this comment

pdcastro commented Jan 5, 2019

xginn8 commented Jan 9, 2019

xginn8 commented Jan 9, 2019

pdcastro left a comment

Choose a reason for hiding this comment

xginn8 commented Jan 10, 2019

Request access to previously pushed release via `balena deploy` #1057

Request access to previously pushed release via `balena deploy` #1057

xginn8 commented Dec 28, 2018 •

edited by pdcastro

Loading