Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for docker-compose dev overlay #2177

Merged
1 commit merged into from
Feb 10, 2021
Merged

Conversation

srlowe
Copy link
Contributor

@srlowe srlowe commented Feb 4, 2021

This allows users to specify a docker-compose.dev.yml file, which is merged in local pushes, and allows extra/alternative services to be declared.

Change-type: minor
Signed-off-by: Scott Lowe [email protected]

@srlowe srlowe force-pushed the livepush-compose-dev-overlay branch from e280206 to 2d64496 Compare February 5, 2021 12:19
@srlowe srlowe requested a review from pdcastro February 5, 2021 12:28
@pdcastro
Copy link
Contributor

pdcastro commented Feb 5, 2021

This allows users to specify a docker-compose.dev.yml file, which is merged in local pushes, and allows extra/alternative services to be declared.

Perhaps the commit message (that goes to the ChangeLog) could mention "local push" (or "push <ip-addr>"), so it's clearer that the feature does not apply to cloud push.

@srlowe srlowe force-pushed the livepush-compose-dev-overlay branch from 2d64496 to f3d750a Compare February 9, 2021 12:15
@srlowe srlowe marked this pull request as ready for review February 9, 2021 12:15
@srlowe srlowe requested a review from a team as a code owner February 9, 2021 12:15
@srlowe srlowe requested a review from pdcastro February 9, 2021 12:19
@ghost ghost merged commit 2a4ff75 into master Feb 10, 2021
@ghost ghost deleted the livepush-compose-dev-overlay branch February 10, 2021 01:26
@maggie44
Copy link

maggie44 commented Apr 1, 2021

Adding here for reference, a change proposal to prevent issues that can occur from this commit using the current naming format: #1142 (comment)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants