Skip to content

Commit

Permalink
upgrade: electron-builder to v19.9.1
Browse files Browse the repository at this point in the history
- Exclude *.dll/*.exe files from the asar in non-Windows operating
  systems (from 19.8.0)

- Correctly parse boolean flags in `--extraMetadata` (in v19.9.0)

See: https://github.com/electron-userland/electron-builder/releases/tag/v19.9.1
Change-Type: patch
Signed-off-by: Juan Cruz Viotti <[email protected]>
  • Loading branch information
jviotti committed Jun 30, 2017
1 parent 9bd987f commit 5f2f3e7
Show file tree
Hide file tree
Showing 4 changed files with 112 additions and 82 deletions.
2 changes: 1 addition & 1 deletion electron-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,5 @@ rpm:
depends:
- lsb
- libXScrnSaver
appimage:
appImage:
icon: assets/icon.png
8 changes: 1 addition & 7 deletions lib/gui/models/store.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,7 @@ const DEFAULT_STATE = Immutable.fromJS({
errorReporting: true,
unmountOnSuccess: true,
validateWriteOnSuccess: true,

// The purpose of JSON.parse() is to convert strings such as "false"
// into boolean values, given that electron-builder is only able to
// inject strings into package.json.
// See https://github.com/electron-userland/electron-builder/issues/1674
updatesEnabled: Boolean(JSON.parse(packageJSON.updates.enabled)),

updatesEnabled: packageJSON.updates.enabled,
includeUnstableUpdateChannel: !release.isStableRelease(packageJSON.version),
lastSleptUpdateNotifier: null,
lastSleptUpdateNotifierVersion: null
Expand Down
182 changes: 109 additions & 73 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"asar": "0.10.0",
"browserify": "github:jviotti/node-browserify#dynamic-dirname-filename",
"electron": "1.6.6",
"electron-builder": "18.6.2",
"electron-builder": "19.9.1",
"electron-mocha": "3.3.0",
"eslint": "3.18.0",
"eslint-plugin-lodash": "2.3.6",
Expand Down

0 comments on commit 5f2f3e7

Please sign in to comment.