Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade(package): Bump mountutils 1.2.2 -> 1.3.8 #1946

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

jhermsmeier
Copy link
Contributor

Change-Type: patch

@jhermsmeier jhermsmeier requested review from lurch, Shou and jviotti January 3, 2018 14:53
@lurch
Copy link
Contributor

lurch commented Jan 3, 2018

Not directly related to this PR, but looking at https://github.com/resin-io-modules/mountutils/releases it seems that it's still only prebuilding x64 modules, and not prebuilding x86 modules?
(I just did some digging and found an old comment here )

@jhermsmeier
Copy link
Contributor Author

@lurch then open an issue on mountutils instead of commenting off topic, please

@lurch
Copy link
Contributor

lurch commented Jan 3, 2018

Sorry Jonas, done that now balena-io-modules/mountutils#62

@jhermsmeier
Copy link
Contributor Author

@lurch is this good to merge though?

Copy link
Contributor

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but should we add a changelog entry?

@jhermsmeier
Copy link
Contributor Author

@jviotti there hasn't really been a change that impacts Etcher in a noticeable way, so I figured a changelog entry would be excess, but can add one

@jviotti
Copy link
Contributor

jviotti commented Jan 4, 2018

Ah, alright, just making sure we didn't miss any important one.

@jhermsmeier jhermsmeier merged commit fdfdcf9 into master Jan 4, 2018
@jhermsmeier jhermsmeier deleted the update-mountutils branch January 4, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants