forked from ggml-org/ggml
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port all operations for metal #2
Open
pminev
wants to merge
16
commits into
balisujohn:tortoise
Choose a base branch
from
alpaca-core:feature/port-commands-metal
base: tortoise
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Port all operations for metal #2
pminev
wants to merge
16
commits into
balisujohn:tortoise
from
alpaca-core:feature/port-commands-metal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- add missing strings in the op names
-- now we must implement it in the shader
-- there is a bug and we don't have audio, but at least no crashes
-- we use all available threads as other funcs in the library, so it runs faster than before
-- if this has worked before maybe it'll be if the src and dst have different size, but in tortose we had to take the params into account to make it work as it should, otherwise there were calculations mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported conv transpose 1d, pad reflect, unfold for metal backend. Had to fix "pad_f32" to add padding in the beginning for metal (part of the port, but it existed, so I had to fix it in the shader).
After all changes, I was able to run Tortoise.cpp with Metal backend. ref issue