Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'bal dist pull' failure in windows #381

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Fix 'bal dist pull' failure in windows #381

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d6da79
Fix 'bal dist pull' failure in windows
NipunaMadhushan Jan 7, 2025
bd92eb8
Address review suggestions
NipunaMadhushan Jan 8, 2025
becc7a5
Update version
NipunaMadhushan Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/main/java/org/ballerinalang/command/util/ToolUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,8 +1033,14 @@ public static String encodePlusCharacters(String dependency) {
private static void addExecutablePermissionToDirectory(String filePath) {
Process process;
try {
process = Runtime.getRuntime().exec("chmod -R 755 " + filePath);
process.waitFor();
if (OSUtils.isWindows()) {
process = Runtime.getRuntime().exec("icacls " + filePath + " /grant Everyone:(OI)(CI)RX /T");
process.waitFor();
}
else {
process = Runtime.getRuntime().exec("chmod -R 755 " + filePath);
process.waitFor();
}
} catch (InterruptedException | IOException e) {
throw ErrorUtil.createCommandException("permission denied: you do not have write access to '" + filePath
+ "'");
Expand Down
Loading