Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename BasicAuth record to Credentials #310

Merged
merged 3 commits into from
Jul 5, 2021
Merged

Rename BasicAuth record to Credentials #310

merged 3 commits into from
Jul 5, 2021

Conversation

Maninda
Copy link
Member

@Maninda Maninda commented Jul 5, 2021

Purpose

Resolves ballerina-platform/ballerina-library#1606

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@Maninda Maninda self-assigned this Jul 5, 2021
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #310 (79994fd) into master (6d37e8b) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #310   +/-   ##
=========================================
  Coverage     84.63%   84.63%           
  Complexity       82       82           
=========================================
  Files            17       17           
  Lines           768      768           
  Branches        108      108           
=========================================
  Hits            650      650           
  Misses           92       92           
  Partials         26       26           
Impacted Files Coverage Δ
ftp-ballerina/commons.bal 100.00% <ø> (ø)
...rg/ballerinalang/stdlib/ftp/util/FtpConstants.java 100.00% <ø> (ø)
...ava/org/ballerinalang/stdlib/ftp/util/FtpUtil.java 79.77% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d37e8b...79994fd. Read the comment docs.

@Maninda Maninda merged commit 76b8281 into master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename BasicAuth record to Credentials in the FTP module
2 participants