Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anonymous FTP #311

Merged
merged 4 commits into from
Jul 6, 2021
Merged

Add anonymous FTP #311

merged 4 commits into from
Jul 6, 2021

Conversation

Maninda
Copy link
Member

@Maninda Maninda commented Jul 6, 2021

Purpose

Resolves ballerina-platform/ballerina-library#1607

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@Maninda Maninda self-assigned this Jul 6, 2021
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #311 (069e0d8) into master (76b8281) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #311      +/-   ##
============================================
+ Coverage     84.63%   84.89%   +0.26%     
- Complexity       82       84       +2     
============================================
  Files            17       17              
  Lines           768      768              
  Branches        108      108              
============================================
+ Hits            650      652       +2     
  Misses           92       92              
+ Partials         26       24       -2     
Impacted Files Coverage Δ
...ava/org/ballerinalang/stdlib/ftp/util/FtpUtil.java 80.89% <100.00%> (+1.12%) ⬆️
...org/ballerinalang/stdlib/ftp/client/FtpClient.java 83.12% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b8281...069e0d8. Read the comment docs.

Maninda and others added 2 commits July 6, 2021 10:34
Copy link
Member

@ldclakmal ldclakmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maninda Maninda merged commit 4abc1f1 into master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the support for anonymous user
3 participants