Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp FTP Listener logic #381

Merged
merged 7 commits into from
Aug 26, 2021
Merged

Revamp FTP Listener logic #381

merged 7 commits into from
Aug 26, 2021

Conversation

Maninda
Copy link
Member

@Maninda Maninda commented Aug 26, 2021

Purpose

Resolves ballerina-platform/ballerina-library#1703

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@Maninda Maninda self-assigned this Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #381 (35f37bd) into master (79d724f) will increase coverage by 0.00%.
The diff coverage is 59.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #381   +/-   ##
=========================================
  Coverage     81.95%   81.95%           
- Complexity      179      185    +6     
=========================================
  Files            29       29           
  Lines          1097     1103    +6     
  Branches        163      163           
=========================================
+ Hits            899      904    +5     
+ Misses          145      144    -1     
- Partials         53       55    +2     
Impacted Files Coverage Δ
...ftp/transport/server/RemoteFileSystemConsumer.java 64.64% <14.28%> (ø)
...tractimpl/RemoteFileSystemServerConnectorImpl.java 70.00% <45.45%> (-5.00%) ⬇️
...va/io/ballerina/stdlib/ftp/server/FtpListener.java 74.57% <51.72%> (-0.43%) ⬇️
ballerina/external_functions.bal 100.00% <100.00%> (ø)
ballerina/listener_endpoint.bal 93.18% <100.00%> (+2.27%) ⬆️
...ballerina/stdlib/ftp/server/FtpListenerHelper.java 77.77% <100.00%> (+3.58%) ⬆️
...ort/impl/RemoteFileSystemConnectorFactoryImpl.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d724f...35f37bd. Read the comment docs.

@Maninda Maninda marked this pull request as ready for review August 26, 2021 10:47
@Maninda Maninda requested a review from ayeshLK August 26, 2021 13:15
@Maninda Maninda merged commit 2a51411 into master Aug 26, 2021
@Maninda Maninda deleted the dev branch August 26, 2021 13:36
@Maninda Maninda mentioned this pull request Aug 31, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp the listener logic of FTP listener
2 participants