Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arraySize parameter from the get method of the FTP Client API #401

Merged
merged 8 commits into from
Sep 24, 2021

Conversation

Maninda
Copy link
Member

@Maninda Maninda commented Sep 24, 2021

Purpose

  1. Resolves Remove arraySize parameter from the get method of the FTP Client API ballerina-library#1940
  2. Improve rmdir test cases

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@Maninda Maninda self-assigned this Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #401 (7a4cf16) into master (b7597d7) will increase coverage by 0.82%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #401      +/-   ##
============================================
+ Coverage     81.91%   82.74%   +0.82%     
- Complexity      186      187       +1     
============================================
  Files            29       29              
  Lines          1106     1101       -5     
  Branches        166      165       -1     
============================================
+ Hits            906      911       +5     
+ Misses          144      134      -10     
  Partials         56       56              
Impacted Files Coverage Δ
ballerina/listener_endpoint.bal 93.18% <ø> (ø)
...ava/io/ballerina/stdlib/ftp/util/FtpConstants.java 100.00% <ø> (ø)
ballerina/byte_stream.bal 84.37% <100.00%> (-0.48%) ⬇️
ballerina/client_endpoint.bal 97.56% <100.00%> (-0.06%) ⬇️
...java/io/ballerina/stdlib/ftp/client/FtpClient.java 84.57% <100.00%> (-0.09%) ⬇️
...o/ballerina/stdlib/ftp/client/FtpClientHelper.java 83.90% <100.00%> (+0.95%) ⬆️
...ftp/transport/server/RemoteFileSystemConsumer.java 70.70% <0.00%> (+6.06%) ⬆️
...tractimpl/RemoteFileSystemServerConnectorImpl.java 80.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7597d7...7a4cf16. Read the comment docs.

@Maninda Maninda marked this pull request as ready for review September 24, 2021 03:00
@Bhashinee
Copy link
Member

When making the WatchEvent read-only, shouldn't we change the native code accordingly?
https://github.com/ballerina-platform/module-ballerina-ftp/blob/master/native/src/main/java/io/ballerina/stdlib/ftp/server/FtpListener.java#L98

by using ValueCreator.createReadonlyRecordValue(...)

@Maninda
Copy link
Member Author

Maninda commented Sep 24, 2021

When making the WatchEvent read-only, shouldn't we change the native code accordingly?
https://github.com/ballerina-platform/module-ballerina-ftp/blob/master/native/src/main/java/io/ballerina/stdlib/ftp/server/FtpListener.java#L98

by using ValueCreator.createReadonlyRecordValue(...)

As discussed offline and after some attempts to implement this change which caused some inconsistencies, I have reverted back the changes related to making the WatchEvent as readonly.

@Maninda Maninda requested a review from Bhashinee September 24, 2021 11:53
@Maninda Maninda requested a review from Bhashinee September 24, 2021 12:05
@Maninda Maninda requested a review from Bhashinee September 24, 2021 12:11
@Maninda Maninda merged commit 995c322 into master Sep 24, 2021
@Maninda Maninda deleted the dev branch September 24, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove arraySize parameter from the get method of the FTP Client API
2 participants