Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commons-net version #835

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Update commons-net version #835

merged 5 commits into from
Dec 8, 2022

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Dec 8, 2022

Purpose

$subject
Fixes ballerina-platform/ballerina-library#3841

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi marked this pull request as ready for review December 8, 2022 10:46
Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 84.38% // Head: 84.00% // Decreases project coverage by -0.38% ⚠️

Coverage data is based on head (f46c84f) compared to base (87aba30).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #835      +/-   ##
============================================
- Coverage     84.38%   84.00%   -0.39%     
  Complexity      227      227              
============================================
  Files            30       30              
  Lines          1294     1294              
  Branches        188      188              
============================================
- Hits           1092     1087       -5     
- Misses          144      149       +5     
  Partials         58       58              
Impacted Files Coverage Δ
...java/io/ballerina/stdlib/ftp/util/ModuleUtils.java 81.81% <71.42%> (ø)
ballerina/init.bal 100.00% <100.00%> (ø)
...tractimpl/RemoteFileSystemServerConnectorImpl.java 70.00% <0.00%> (-10.00%) ⬇️
...ftp/transport/server/RemoteFileSystemConsumer.java 72.97% <0.00%> (-2.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dilanSachi dilanSachi merged commit 7a89843 into master Dec 8, 2022
@dilanSachi dilanSachi deleted the dilanSachi-patch-1 branch December 8, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update commons-net version for FTP and remove TestNG from project depdendencies
2 participants