Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement WebSub Compiler Plugin #166

Merged
merged 57 commits into from
Apr 16, 2021
Merged

Implement WebSub Compiler Plugin #166

merged 57 commits into from
Apr 16, 2021

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Mar 31, 2021 •
edited
Loading

Purpose

This implements a compiler plugin for ballerina WebSub Service.

Fixes: #1099

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

ayeshLK added 17 commits March 16, 2021 21:05
@ayeshLK
Minor refactoring to public methods in resource-discovery / subscribe…
43679c1 
…r-listener
@ayeshLK
Add initial structure for websub-compiler-plugin
4a8b13e
@ayeshLK
Add a syntax-validator to validate checkpanic usage
6dac7e2
@ayeshLK
Integrated compiler plugin build to websub-build
7cdf2a5
@ayeshLK
Add basic structure for required validators for compiler plugin
3737553
@ayeshLK
Add compiler-plugin test module
5d4b482
@ayeshLK
Add basic websub-service validation for compiler-plugin
0ae1a0a
@ayeshLK
Merge branch 'master' into compiler_plugin
06fb226
@ayeshLK
Fix issue in validator and spot-bug configuration
65fd756
@ayeshLK
Add validation to required method implementation in the service
b8a50f8
@ayeshLK
Resolve merge conflicts
cb7dc40
@ayeshLK
Merge branch 'master' into compiler_plugin
d18cc8b
@ayeshLK
Add remote-method validation for compiler plugin
95feb0e
@ayeshLK
Remove unwanted constants.
8548586
@ayeshLK
Add websub service-declaration validation with test-cases
20b71ba
@ayeshLK
Merge branch 'master' into compiler_plugin
0c8f8a8
@ayeshLK
Refactor code base
b47b3b9
@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #166 (803e956) into master (e10fec4) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
+ Coverage     82.81%   82.95%   +0.14%     
  Complexity        9        9              
============================================
  Files            12       12              
  Lines           576      575       -1     
  Branches        306      305       -1     
============================================
  Hits            477      477              
+ Misses           99       98       -1
Impacted Files Coverage Δ Complexity Δ
websub-ballerina/sub_listener.bal 87.60% <ø> (+0.71%) 0.00 <0.00> (ø)
websub-ballerina/subscriber_client.bal 64.13% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1188fb...803e956. Read the comment docs.

ayeshLK added 17 commits April 9, 2021 12:37
@ayeshLK
Update parameter type validation logic
ae73934
@ayeshLK
Fix issue is type checking for service method parameters
34329cc
@ayeshLK
Refactor type checking logic
3aa87c8
@ayeshLK
Refactor strucutre of the code base and update listener init validati…
3585eb1 
…on to use semantic model
@ayeshLK
Merge branch 'master' into compiler_plugin
1e77e8d
@ayeshLK
Fix issue in param type validation
cf35a12
@ayeshLK
Refactor service validator code base and update function param type v…
7cce0aa 
…alidation with semantic model
@ayeshLK
Revert versioning related placeholder values
77dd571
@ayeshLK
Refactor param type validation with error types
9f09677
@ayeshLK
Merge branch 'master' into compiler_plugin
eb1a428
@ayeshLK
Fix issue in using type-symbol with error types
a061da1
@ayeshLK
Migrate all the validation to use semantic model
3a0ebb4
@ayeshLK
Add doc-comments for undocumented parameters
1ba6a8f
@ayeshLK
Fix year in copyright template
f790d3e
@ayeshLK
Fix the doc comment in compiler plugin tests
8c7e7ce
@ayeshLK
Update change log for the next release
5fbde34
@ayeshLK
Add copyright statement to the codebase
4ec9682
@ayeshLK
Copy link
Member Author

ayeshLK commented Apr 16, 2021

@shafreenAnfar / @ldclakmal / @chamil321 / @ThisaruGuruge / @Bhashinee / @aashikam please review this

@ayeshLK ayeshLK changed the base branch from compiler_plugin_impl to master April 16, 2021 14:15
@shafreenAnfar shafreenAnfar merged commit a69aef2 into ballerina-platform:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chamil321 chamil321 chamil321 left review comments

@madhukaw madhukaw madhukaw left review comments

@shafreenAnfar shafreenAnfar shafreenAnfar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a Compiler Plugin to Validate WebSub Service
4 participants
@ayeshLK @shafreenAnfar @chamil321 @madhukaw