Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve public APIs to return only module specific errors #291

Merged
merged 8 commits into from
Jun 17, 2021

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Jun 17, 2021

Purpose

$subject

Part of #1487

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #291 (a7e2406) into master (f91192f) will decrease coverage by 2.00%.
The diff coverage is 67.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   88.63%   86.63%   -2.01%     
==========================================
  Files          10       10              
  Lines         528      546      +18     
  Branches      292      306      +14     
==========================================
+ Hits          468      473       +5     
- Misses         60       73      +13     
Impacted Files Coverage Δ
websub-ballerina/http_service.bal 85.71% <ø> (ø)
websub-ballerina/native.bal 100.00% <ø> (ø)
websub-ballerina/sub_listener.bal 84.50% <63.33%> (-5.82%) ⬇️
websub-ballerina/utils.bal 89.07% <66.66%> (-2.52%) ⬇️
websub-ballerina/resource_discovery.bal 78.78% <100.00%> (-0.38%) ⬇️
websub-ballerina/subscriber_client.bal 85.18% <100.00%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91192f...a7e2406. Read the comment docs.

@ayeshLK ayeshLK changed the title Improve public API to return only module specific errors Improve public APIs to return only module specific errors Jun 17, 2021
@shafreenAnfar shafreenAnfar merged commit bc62c18 into ballerina-platform:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants