Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor subscription/unsubscription flows #1080

Merged
merged 14 commits into from
Feb 17, 2025

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Feb 13, 2025

Purpose

$subject

Fixes: #7586

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@ayeshLK ayeshLK requested review from daneshk and removed request for shafreenAnfar February 13, 2025 20:21
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 83.57143% with 23 lines in your changes missing coverage. Please review.

Project coverage is 87.80%. Comparing base (def0849) to head (3e30d3d).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
ballerina/subscription.bal 83.13% 14 Missing ⚠️
ballerina/http_service.bal 83.33% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1080      +/-   ##
============================================
- Coverage     88.19%   87.80%   -0.40%     
  Complexity       37       37              
============================================
  Files            13       13              
  Lines           788      787       -1     
  Branches        221      224       +3     
============================================
- Hits            695      691       -4     
- Misses           90       93       +3     
  Partials          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ayeshLK ayeshLK merged commit cbed44d into ballerina-platform:main Feb 17, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor websubhub subscription/unsubcription flow
2 participants