Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include auth-config to websubhub ClientConfiguration #131

Merged
merged 4 commits into from
May 5, 2021

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented May 5, 2021

Purpose

$subject

Fixes #1324

Examples

  • With auth-config websubhub:PublisherClient could be initialized as follows.
    websubhub:PublisherClient publsherClient = check new("https://localhost:9090/websubhub",
        auth = {
            username: "ballerina",
            issuer: "wso2",
            audience: ["ballerina", "ballerina.org", "ballerina.io"],
            keyId: "KEY_ID",
            jwtId: "JWT_ID",
            customClaims: { "scp": "hello" },
            expTime: 3600,
            signatureConfig: {
                config: {
                    keyFile: "../resources/private.key"
                }
            }
        },
        secureSocket = {
            cert: "../resources/public.crt"
        }
    );

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #131 (5a4f3b7) into main (b894f9e) will increase coverage by 1.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #131      +/-   ##
============================================
+ Coverage     80.75%   81.77%   +1.02%     
  Complexity       14       14              
============================================
  Files            11       11              
  Lines           800      801       +1     
  Branches        436      436              
============================================
+ Hits            646      655       +9     
+ Misses          154      146       -8     
Impacted Files Coverage Δ Complexity Δ
websubhub-ballerina/commons.bal 90.00% <100.00%> (+0.16%) 0.00 <0.00> (ø)
websubhub-ballerina/utils.bal 77.50% <0.00%> (+3.33%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b894f9e...5a4f3b7. Read the comment docs.

@ldclakmal ldclakmal merged commit 1d8edd2 into ballerina-platform:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth Configuration is missing from WebSubHub PublisherClient configuration
3 participants