Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HTTP Service Inside the WebSubHub Listener an Isolated Object #160

Merged
merged 8 commits into from
May 24, 2021

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented May 22, 2021

Purpose

$subject

Fixes #1390

Checklist

  • Linked to an issue
  • Updated the changelog
    Added tests N/A

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #160 (524107f) into main (a6de916) will decrease coverage by 0.39%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   83.05%   82.65%   -0.40%     
==========================================
  Files           9        9              
  Lines         773      761      -12     
  Branches      438      443       +5     
==========================================
- Hits          642      629      -13     
- Misses        131      132       +1     
Impacted Files Coverage Δ
websubhub-ballerina/hub_listener.bal 86.66% <75.00%> (+0.30%) ⬆️
websubhub-ballerina/utils.bal 80.91% <90.00%> (ø)
websubhub-ballerina/natives.bal 93.33% <93.33%> (+4.44%) ⬆️
websubhub-ballerina/http_service.bal 78.62% <94.11%> (-3.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6de916...524107f. Read the comment docs.

@ayeshLK ayeshLK changed the title Make HTTP Service Inside the WebSub Listener an Isolated Object Make HTTP Service Inside the WebSubHub Listener an Isolated Object May 24, 2021
@shafreenAnfar shafreenAnfar merged commit 68e0ce7 into ballerina-platform:main May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make HTTP Service Class Isolated in WebSubHub
2 participants