-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log error when the return from the remote method leads to an error #200
Merged
chamil321
merged 12 commits into
ballerina-platform:main
from
ayeshLK:build_stabilization
Jun 15, 2021
Merged
Log error when the return from the remote method leads to an error #200
chamil321
merged 12 commits into
ballerina-platform:main
from
ayeshLK:build_stabilization
Jun 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 83.41% 83.67% +0.25%
==========================================
Files 9 9
Lines 784 784
Branches 454 454
==========================================
+ Hits 654 656 +2
+ Misses 130 128 -2
Continue to review full report at Codecov.
|
chamil321
reviewed
Jun 11, 2021
websubhub-native/src/main/java/io/ballerina/stdlib/websubhub/HubCallback.java
Show resolved
Hide resolved
websubhub-native/src/main/java/io/ballerina/stdlib/websubhub/HubCallback.java
Outdated
Show resolved
Hide resolved
chamil321
reviewed
Jun 11, 2021
websubhub-native/src/main/java/io/ballerina/stdlib/websubhub/NativeHttpToWebsubhubAdaptor.java
Outdated
Show resolved
Hide resolved
chamil321
approved these changes
Jun 14, 2021
chamil321
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1449
Examples
Checklist
Added testsN/A