Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebSub Compliance issues in Hub #211

Merged
merged 15 commits into from
Jun 16, 2021

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Jun 16, 2021

Purpose

$subject

WebSubHub subscription/unsubscription verification should be WebSubRocks Compliant.

Fixes #1479

WebSubHub should be able to infer the event-type for content-distribution based on content-type and request-body.

Fixes #1460

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@ayeshLK ayeshLK marked this pull request as draft June 16, 2021 11:56
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #211 (f393062) into main (b5c860c) will increase coverage by 1.03%.
The diff coverage is 84.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   83.67%   84.71%   +1.03%     
==========================================
  Files           9       11       +2     
  Lines         784      785       +1     
  Branches      454      460       +6     
==========================================
+ Hits          656      665       +9     
+ Misses        128      120       -8     
Impacted Files Coverage Δ
websubhub-ballerina/utils.bal 77.92% <ø> (-3.83%) ⬇️
websubhub-ballerina/http_service.bal 85.43% <60.00%> (+4.61%) ⬆️
websubhub-ballerina/subscription.bal 80.64% <80.64%> (ø)
websubhub-ballerina/content_distribution.bal 96.22% <96.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c860c...f393062. Read the comment docs.

@ayeshLK ayeshLK marked this pull request as ready for review June 16, 2021 16:19
@shafreenAnfar shafreenAnfar merged commit 81a7484 into ballerina-platform:main Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants