Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Compiler plugin crashes when using a new-expr with a user-defined class in the same source #495

Merged
merged 6 commits into from
Mar 29, 2022
Merged

[FIX] Compiler plugin crashes when using a new-expr with a user-defined class in the same source #495

merged 6 commits into from
Mar 29, 2022

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Mar 29, 2022

Purpose

$subject

Fixes #2815

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec

@ayeshLK ayeshLK requested a review from shafreenAnfar as a code owner March 29, 2022 03:45
@ayeshLK ayeshLK requested a review from chamil321 March 29, 2022 03:45
@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #495 (38f852f) into main (4188680) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #495   +/-   ##
=========================================
  Coverage     88.50%   88.50%           
  Complexity       37       37           
=========================================
  Files            15       15           
  Lines           844      844           
  Branches        461      461           
=========================================
  Hits            747      747           
  Misses           93       93           
  Partials          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68fa8e0...38f852f. Read the comment docs.

ThisaruGuruge
ThisaruGuruge approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayeshLK ayeshLK merged commit e9a5cd1 into ballerina-platform:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThisaruGuruge ThisaruGuruge ThisaruGuruge approved these changes

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

@chamil321 chamil321 Awaiting requested review from chamil321

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler plugin crashes when using a new-expr with a user-defined class in the same source
2 participants
@ayeshLK @ThisaruGuruge