[FIX] Compiler plugin validation logic for websubhub:Listener args when a check expression is present
#748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.91% // Head: 88.91% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
=========================================
Coverage 88.91% 88.91%
Complexity 37 37
=========================================
Files 15 15
Lines 839 839
Branches 452 452
=========================================
Hits 746 746
Misses 89 89
Partials 4 4 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
compiler-plugin-tests/src/test/resources/ballerina_sources/sample_22/service.bal
Outdated
Show resolved
Hide resolved
compiler-plugin-tests/src/test/resources/ballerina_sources/sample_22/service.bal
Outdated
Show resolved
Hide resolved
ayeshLK
requested review from
chamil321
and removed request for
shafreenAnfar
chamil321
reviewed
Nov 1, 2022
compiler-plugin-tests/src/test/resources/ballerina_sources/sample_22/service.bal
Outdated
Show resolved
Hide resolved
compiler-plugin-tests/src/test/resources/ballerina_sources/sample_22/service.bal
Outdated
Show resolved
Hide resolved
compiler-plugin-tests/src/test/resources/ballerina_sources/sample_22/service.bal
Outdated
Show resolved
Hide resolved
chamil321
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #2782
Examples
N/A
Checklist
Updated the specChecked native-image compatibility