Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.4.x] Fix logic issue in ServiceExecutionError not getting properly populated with error details when there is a panic from within the websubhub:Service #808

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Mar 16, 2023

Purpose

$subject

Fixes: #4217

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@ayeshLK ayeshLK requested a review from shafreenAnfar as a code owner March 16, 2023 10:45
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.22 ⚠️

Comparison is base (34a3a74) 88.95% compared to head (0235ca5) 88.74%.

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.4.x     #808      +/-   ##
==============================================
- Coverage       88.95%   88.74%   -0.22%     
  Complexity         37       37              
==============================================
  Files              15       15              
  Lines             842      844       +2     
  Branches          448      448              
==============================================
  Hits              749      749              
- Misses             89       91       +2     
  Partials            4        4              
Impacted Files Coverage Δ
...ava/io/ballerina/stdlib/websubhub/HubCallback.java 63.63% <0.00%> (-6.37%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ayeshLK ayeshLK merged commit f165f75 into ballerina-platform:2201.4.x Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants