Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.7.x] [Fix] Additional parameters sent in the subscription request is not properly propagated into the websubhub:VerifiedSubscription message #870

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Sep 14, 2023

Purpose

$subject

Fixes: #4800

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14% ⚠️

Comparison is base (2d2c956) 89.16% compared to head (d3a94f7) 89.03%.

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.7.x     #870      +/-   ##
==============================================
- Coverage       89.16%   89.03%   -0.14%     
  Complexity         37       37              
==============================================
  Files              15       15              
  Lines             840      830      -10     
  Branches          448      448              
==============================================
- Hits              749      739      -10     
  Misses             87       87              
  Partials            4        4              
Files Changed Coverage Δ
ballerina/subscription.bal 89.47% <ø> (-0.85%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants