Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Main] [Fix] Additional parameters sent in the subscription request is not properly propagated into the websubhub:VerifiedSubscription message #872

Merged
merged 2 commits into from
Sep 15, 2023
Merged

[Main] [Fix] Additional parameters sent in the subscription request is not properly propagated into the websubhub:VerifiedSubscription message #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f22085f
[Automated] Update the native jar versions
ayeshLK Sep 15, 2023
d6ce50b
Copy additional parameters sent in the subscription request to the ve…
ayeshLK Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ballerina/Dependencies.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

[ballerina]
dependencies-toml-version = "2"
distribution-version = "2201.8.0-20230726-145300-b2bdf796"
distribution-version = "2201.8.0-20230908-135700-74a59dff"

[[package]]
org = "ballerina"
Expand Down
12 changes: 2 additions & 10 deletions ballerina/subscription.bal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,7 @@ isolated function processSubscriptionVerification(http:Headers headers, HttpToWe
string respStringPayload = check subscriberResponse.getTextPayload();
if (respStringPayload == challenge) {
VerifiedSubscription verifiedMessage = {
hub: message.hub,
hubMode: message.hubMode,
hubCallback: message.hubCallback,
hubTopic: message.hubTopic,
hubLeaseSeconds: message.hubLeaseSeconds,
hubSecret: message.hubSecret
...message
};
check adaptor.callOnSubscriptionIntentVerifiedMethod(verifiedMessage, headers);
}
Expand Down Expand Up @@ -186,10 +181,7 @@ isolated function processUnSubscriptionVerification(http:Headers headers, HttpTo
string respStringPayload = check subscriberResponse.getTextPayload();
if (respStringPayload == challenge) {
VerifiedUnsubscription verifiedMessage = {
hubMode: message.hubMode,
hubCallback: message.hubCallback,
hubTopic: message.hubTopic,
hubSecret: message.hubSecret
...message
};
check adaptor.callOnUnsubscriptionIntentVerifiedMethod(verifiedMessage, headers);
}
Expand Down
5 changes: 5 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.9.1] - 2023-09-14

### Fixed
- [Additional parameters sent in the subscription request is not properly propagated into the `websubhub:VerifiedSubscription` message](https://github.com/ballerina-platform/ballerina-standard-library/issues/4800)

## [1.5.1] - 2023-03-16

### Fixed
Expand Down