-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement websubhub:ServiceConfig annotation for websubhub:Service #96
Implement websubhub:ServiceConfig annotation for websubhub:Service #96
Conversation
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
============================================
+ Coverage 75.61% 80.75% +5.13%
- Complexity 13 14 +1
============================================
Files 10 11 +1
Lines 771 800 +29
Branches 430 436 +6
============================================
+ Hits 583 646 +63
+ Misses 188 154 -34
Continue to review full report at Codecov.
|
Co-authored-by: Chanaka Lakmal <[email protected]>
Co-authored-by: Chanaka Lakmal <[email protected]>
Co-authored-by: Chanaka Lakmal <[email protected]>
Co-authored-by: Chanaka Lakmal <[email protected]>
…ina-websubhub into http_client_config
…:ClientConfiguration fields
Co-authored-by: Chanaka Lakmal <[email protected]>
…ina-websubhub into http_client_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Fixes 1253
Fixes 1249
Examples
websubhub:ClientConfiguration
which could be used forwebsubhub:HubClient
/websubhub:PublisherClient
is as follows.websubhub:ServiceConfig
is an optional annotation configuration which could be included towebsubhub:Service
declaration. Following is a sample on how to use thewebsubhub:ServiceConfig
.leaseSeconds
parameter is used to identify the subscription deactivation.webHookConfig
is used for underlyinghttp:Client
used for subscription and unsubscription verification.Checklist