Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in toXml API and update the docs #470

Merged
merged 8 commits into from
Jan 25, 2023

Conversation

kalaiyarasiganeshalingam
Copy link
Contributor

@kalaiyarasiganeshalingam kalaiyarasiganeshalingam commented Dec 6, 2022

Purpose

$Subject

Fixes ballerina-platform/ballerina-library#3713
ballerina-platform/ballerina-library#3716

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 88.24% // Head: 88.86% // Increases project coverage by +0.61% 🎉

Coverage data is based on head (0ede599) compared to base (5b05c84).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #470      +/-   ##
============================================
+ Coverage     88.24%   88.86%   +0.61%     
- Complexity      215      220       +5     
============================================
  Files             8        8              
  Lines           817      835      +18     
  Branches        284      282       -2     
============================================
+ Hits            721      742      +21     
+ Misses           56       54       -2     
+ Partials         40       39       -1     
Impacted Files Coverage Δ
...a/io/ballerina/stdlib/xmldata/utils/Constants.java 100.00% <ø> (ø)
...o/ballerina/stdlib/xmldata/utils/XmlDataUtils.java 95.69% <89.18%> (+1.65%) ⬆️
ballerina/xmldata.bal 96.89% <100.00%> (+0.53%) ⬆️
...in/java/io/ballerina/stdlib/xmldata/XmlToJson.java 82.58% <0.00%> (-0.05%) ⬇️
...n/java/io/ballerina/stdlib/xmldata/MapFromXml.java 86.88% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kalaiyarasiganeshalingam kalaiyarasiganeshalingam changed the title Fix issues in toXml API Fix issues in toXml API and update the docs Dec 8, 2022
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Dec 24, 2022
@github-actions
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Dec 28, 2022
@daneshk daneshk reopened this Jan 2, 2023
@daneshk daneshk removed the Stale label Jan 2, 2023
@daneshk daneshk merged commit e402d9c into ballerina-platform:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not clear from the API alone that fromXML can used to convert XML to record
2 participants