Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit service after a panic happens inside the onConsumerRecord method and onError method #822

Merged
merged 6 commits into from
Mar 22, 2023

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Mar 22, 2023

Purpose

$subject
Related to ballerina-platform/ballerina-library#4241
Tested the scenarios locally since we cannot add tests to this as System.exit will exit the complete test suite in the runtime.

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi marked this pull request as ready for review March 22, 2023 11:54
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.45 ⚠️

Comparison is base (55d881e) 82.36% compared to head (a93dde0) 81.92%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #822      +/-   ##
============================================
- Coverage     82.36%   81.92%   -0.45%     
+ Complexity      467      466       -1     
============================================
  Files            48       48              
  Lines          2280     2290      +10     
  Branches        352      354       +2     
============================================
- Hits           1878     1876       -2     
- Misses          254      265      +11     
- Partials        148      149       +1     
Impacted Files Coverage Δ
...tdlib/kafka/impl/KafkaPollCycleFutureListener.java 38.88% <0.00%> (-34.45%) ⬇️
...ballerina/stdlib/kafka/impl/KafkaListenerImpl.java 78.51% <28.57%> (-2.74%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dilanSachi dilanSachi merged commit f6b1325 into ballerina-platform:master Mar 22, 2023
@dilanSachi dilanSachi deleted the exit-service branch March 22, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants