Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search bar to Bandada docs #476

Closed
vplasencia opened this issue Apr 7, 2024 · 15 comments · Fixed by #502
Closed

Add search bar to Bandada docs #476

vplasencia opened this issue Apr 7, 2024 · 15 comments · Fixed by #502
Assignees
Labels
feature 🚀 This is enhancing something existing or creating something new
Milestone

Comments

@vplasencia
Copy link
Member

Description

Add Algolia DocSearch.

https://docusaurus.io/docs/search#using-algolia-docsearch

@vplasencia vplasencia added the feature 🚀 This is enhancing something existing or creating something new label Apr 7, 2024
@vplasencia vplasencia added this to the 4. Dione milestone Apr 7, 2024
@vplasencia vplasencia moved this to ♻️ Grooming in Bandada Board Apr 7, 2024
@JoshdfG
Copy link

JoshdfG commented Apr 28, 2024

i would love to do this

@vplasencia
Copy link
Member Author

Hey @JoshdfG! Yes, sure. Would you like me to assign you this issue?

@JoshdfG
Copy link

JoshdfG commented Apr 28, 2024

Yes Please

@JoshdfG
Copy link

JoshdfG commented Apr 28, 2024

Yes but then where on the page do you want the search bar to be
I looked into it just now

@vplasencia
Copy link
Member Author

@JoshdfG I just assigned you the issue. Thanks.

Yes but then where on the page do you want the search bar to be
I looked into it just now

It would be similar to this website: https://docs.semaphore.pse.dev/

Let us know if you have more questions.

@vplasencia
Copy link
Member Author

@JoshdfG

We have to apply to the DocSearch program as mentioned in the docs, but feel free to start with the user interface.

@JoshdfG
Copy link

JoshdfG commented Apr 28, 2024

I still have more questions, do you like need a new page like the website you sent to me? what should be the content? and how should it be done so i can know how well to carry this out.. i just need clarity
Screenshot from 2024-04-29 00-08-57
should i just extract the texts here and put there or what exactly do you want me to do??

@vplasencia
Copy link
Member Author

Hey @JoshdfG

More context

The idea of this issue is to integrate Algolia DocSearch. This is an input field to add text and find information in the docs easier.

It is a small input text that you can see in the header of these websites:
https://docs.semaphore.pse.dev/
https://docusaurus.io/docs/search#using-algolia-docsearch

This is what it looks like:

Screenshot 2024-04-30 at 11 38 10 AM

Important update: We applied to the DocSearch program. When we have the appId, apiKey and indexName we will let you know to update these values.

How to integrate it

You can read more in the docs. The link is in the issue description.

These would be the steps to integrate it into Bandada.

1- Add the search input text.

To do this, copy this code here https://github.com/semaphore-protocol/semaphore/blob/main/apps/docs/docusaurus.config.ts#L120-L125 and paste it here https://github.com/bandada-infra/bandada/blob/main/apps/docs/docusaurus.config.ts#L129

Then you should see a search bar in the header like on the other websites.

Feel free to use those values to test, we will update them when we have the right ones.

2- Modify the styles.

The input text will have some default styles. It would be nice to have a style similar to the page, then you can copy the css code that is here https://docusaurus.io/docs/search#styling-your-algolia-search and paste it here https://github.com/bandada-infra/bandada/blob/main/apps/docs/src/css/custom.css#L42

Then you will see that the style of the search bar is different when you click on it.

Those are the two steps to solve this issue. The 3rd one would be to update the algolia values (appId, apiKey and indexName) to use the right ones when we have them.

I hope this helps. Please, let us know if you have more questions.

@vplasencia vplasencia moved this from ♻️ Grooming to 🗒 Tasks in Bandada Board Apr 30, 2024
@vplasencia
Copy link
Member Author

Hey @JoshdfG!

Update: Bandada has appId, apiKey and indexName now.

@JoshdfG
Copy link

JoshdfG commented May 1, 2024 via email

@vplasencia
Copy link
Member Author

Hey @JoshdfG

The search bar should be in the header of the website, in a way that no matter the page you're visiting, you will be able to see it. The header is the default position when you start integrating the search bar using the step one in the previous steps here: #476 (comment).

Then, there is no need to change position because the search bar should be in the header and that's the default position when you integrate it.

Does this answer your question? Please let me know if it's still unclear.

@vplasencia
Copy link
Member Author

Hey @JoshdfG just to follow up on this. Do you need help with something?

@JoshdfG
Copy link

JoshdfG commented May 8, 2024 via email

@vplasencia
Copy link
Member Author

@JoshdfG! No worries, I just wanted to check if everything was fine. Thanks for the response.

@JoshdfG
Copy link

JoshdfG commented May 8, 2024 via email

@vplasencia vplasencia linked a pull request May 15, 2024 that will close this issue
1 task
vplasencia added a commit that referenced this issue May 15, 2024
Add search bar to Bandada docs #476
vplasencia added a commit that referenced this issue May 17, 2024
Add search bar to Bandada docs #476
@github-project-automation github-project-automation bot moved this from 🗒 Tasks to ✅ Done in Bandada Board May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants