[Tunnel] implement route - router #495
Open
+2,644
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain into tunnel-router-route
added 2 commits
January 27, 2025 22:59
RogerKSI
requested changes
Feb 4, 2025
| @@ -0,0 +1 @@ | |||
| bandd tx tunnel create-tunnel router router17c2txg2px6vna8a6v4ql4eh4ruvprerhytxvwt2ugp4qr473pajsyj9pgm 17000 0xDFCfEbF22e85193eDc37b8b136d4F3394987d1AE 300000 10000000 1000000000uband 1000 ./scripts/tunnel/signal_deviations.json --from requester --keyring-backend test --gas-prices 0.0025uband -y --chain-id bandchain | |||
There was a problem hiding this comment.
do we need to update this? look like router contract should not be used anymore?
Comment on lines
+21
to
+22
| DefaultRouterIBCChannel = "channel-0" | ||
| DefaultRouterIntegrationContract = "router17c2txg2px6vna8a6v4ql4eh4ruvprerhytxvwt2ugp4qr473pajsyj9pgm" |
There was a problem hiding this comment.
- remove default for channel
- contract will be the same for both testnet and mainnet? if not, please remove it.
Comment on lines
+83
to
+95
| message RouterRoute { | ||
| option (cosmos_proto.implements_interface) = "RouteI"; | ||
|
|
||
| // destination_chain_id is the destination chain ID | ||
| string destination_chain_id = 3 [(gogoproto.customname) = "DestinationChainID"]; | ||
| // destination_contract_address is the destination contract address | ||
| string destination_contract_address = 4; | ||
| // destination_gas_limit is the destination gas limit | ||
| uint64 destination_gas_limit = 5; | ||
| // destination_gas_price is the destination gas price | ||
| uint64 destination_gas_price = 6; | ||
| } | ||
|
|
There was a problem hiding this comment.
start running number from 1
| func GetTxCmdUpdateRouterRoute() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "router [tunnel-id] [destination-chain-id] [destination-contract-address] [destination-gas-limit] [destination-gas-price]", | ||
| Short: "Update router route of a router tunnel", |
There was a problem hiding this comment.
should we use Router (big R) instead when we mention the name?
Comment on lines
+75
to
+79
| case *types.RouterRoute: | ||
| _, found := k.channelKeeper.GetChannel(ctx, ibctransfertypes.PortID, routerIBCChannel) | ||
| if !found { | ||
| return nil, types.ErrInvalidChannelID | ||
| } |
There was a problem hiding this comment.
don't think need to check it for Router. it should always be available.
Also, if it's not, it can't be reliable and it can be changed later from params.
wdyt?.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)