Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP-Builder: Introduce new Select control for enum #84

Merged
merged 2 commits into from
Aug 2, 2023
Merged

WP-Builder: Introduce new Select control for enum #84

merged 2 commits into from
Aug 2, 2023

Conversation

bangank36
Copy link
Owner

@bangank36 bangank36 commented Aug 1, 2023 •
edited
Loading

Summary

  • Implement enum based on json schema
  1. SelectControl when uischema options autocomplete false
image 
{
          type: 'Control',
          scope: '#/properties/plainEnum',
          options: {
            autocomplete: false,
          },
        },
  1. ComboboxControl by default (with text input suggestions)
image

Reference

#74

@bangank36 bangank36 self-assigned this Aug 1, 2023
@bangank36 bangank36 added the enhancement New feature or request label Aug 1, 2023
bangank36
bangank36 commented Aug 2, 2023
View reviewed changes
Copy link
Owner Author

@bangank36 bangank36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bangank36 bangank36 merged commit 48809db into main Aug 2, 2023
@bangank36 bangank36 mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bangank36 bangank36

Labels
enhancement New feature or request
Projects
Personal Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bangank36