WP-Builder: Feat/colorPalette-implementation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangank36
commented
Jul 3, 2023
| scope: "#/properties/colorPaletteControl", | ||
| options: { | ||
| format: 'color', | ||
| colors:[ |
There was a problem hiding this comment.
options.colors is new option prop used for the new palette control
| @@ -5,6 +5,9 @@ import ReactDOM from "react-dom"; | |||
| // include your styles into the webpack bundle | |||
| import "../styles/index.css"; | |||
|
|
|||
| // include @wordpress/components styles | |||
| import '@wordpress/components/build-style/style.css'; | |||
There was a problem hiding this comment.
missing style leads to mismatch renderer
| ) | ||
| }; | ||
|
|
||
| const optionIsNotEmpty = |
There was a problem hiding this comment.
nit: should move this tester into seperate file, will come back later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
optionIsNotEmptymethod should move to new file when needed, it will expect acolorsprop inoptionsobject to display a regular color picker ( implemented soon ) or a palette pickerReference
Framer motionlib makes the popover broken has been address and fixed in this issue https://togithub.com/WordPress/gutenberg/issues/51893