Add Response media type detection #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 14, 2021 08:31
The custom response type wraps the webob type with some modest changes.
The tests were passing, but we weren't at project standards. I was assigning None to typed variables without Optional. We had a test that would have failed, but for the same name overwriting it later in the file. And there were issues with the types in the attributes of the Response where I wanted to set some properties to None at this time, but I didn't type them as Optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We're making media_types exclusive with a method on the custom response which allows as to set them appropriately.
Addresses #29
Why?
Proper rendering of the content depends upon the media_content.
How?
Responsetype to wrap the one we've been using from pylonsproject'swebob.set_body_and_content_typeto encode body to match content-type.Testing?
We test that the response helper performs as expected for json, text, and html in
test_text_response_helper,test_html_response_helper, andtest_json_response_helper. We also test manually setting the body withtest_manually_setting_body.