-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set page title #512
fix: set page title #512
Conversation
Preview DeploymentSites https://pr-512-sites--bangumi-next.netlify.app Storybook https://pr-512-storybook--bangumi-next.netlify.app |
#473 这个呢( |
要不等这个合进去了那边再加? |
那我 @FoundTheWOUT ( |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #512 +/- ##
==========================================
+ Coverage 82.93% 83.02% +0.08%
==========================================
Files 95 96 +1
Lines 5803 5832 +29
Branches 460 460
==========================================
+ Hits 4813 4842 +29
Misses 983 983
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
那就先把这个合了? |
packages/website/src/pages/index/group/[name]/new_topic/index.tsx
Outdated
Show resolved
Hide resolved
话说,如果 Helmet 用了两次会怎样,就比方说在 layout 用了 Helmet,然后在 page 里又用了一次 Helmet |
Helmet 不能嵌套使用,如果平级的两个 Component 都用了 Helmet 会合并结果,如有相同的元素后者会覆盖前者:https://github.com/nfl/react-helmet#example |
Fix #438
未完成的页面(比如维基编辑历史)还没接入数据,就先不改了