Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set page title #512

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix: set page title #512

merged 3 commits into from
Mar 31, 2023

Conversation

y-young
Copy link
Contributor

@y-young y-young commented Mar 29, 2023

Fix #438

未完成的页面(比如维基编辑历史)还没接入数据,就先不改了

@mergify mergify bot added the waiting-approval waiting code reviewers to approval PR label Mar 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

@trim21
Copy link
Contributor

trim21 commented Mar 29, 2023

#473 这个呢(

@y-young
Copy link
Contributor Author

y-young commented Mar 29, 2023

#473 这个呢(

要不等这个合进去了那边再加?

@trim21
Copy link
Contributor

trim21 commented Mar 29, 2023

#473 这个呢(

要不等这个合进去了那边再加?

那我 @FoundTheWOUT (

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (20da6f7) 82.93% compared to head (c2260de) 83.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
+ Coverage   82.93%   83.02%   +0.08%     
==========================================
  Files          95       96       +1     
  Lines        5803     5832      +29     
  Branches      460      460              
==========================================
+ Hits         4813     4842      +29     
  Misses        983      983              
  Partials        7        7              
Impacted Files Coverage Δ
packages/website/src/components/Helmet.tsx 100.00% <100.00%> (ø)
...bsite/src/pages/index/group/[name]/index/index.tsx 92.98% <100.00%> (+0.25%) ⬆️
...ite/src/pages/index/group/[name]/index/members.tsx 91.86% <100.00%> (+0.83%) ⬆️
packages/website/src/pages/login/index.tsx 95.03% <100.00%> (+0.14%) ⬆️
packages/website/src/utils/test-utils.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FoundTheWOUT
Copy link
Contributor

那就先把这个合了?

@trim21 trim21 requested a review from FoundTheWOUT March 29, 2023 07:52
@FoundTheWOUT
Copy link
Contributor

话说,如果 Helmet 用了两次会怎样,就比方说在 layout 用了 Helmet,然后在 page 里又用了一次 Helmet

@y-young
Copy link
Contributor Author

y-young commented Mar 29, 2023

话说,如果 Helmet 用了两次会怎样,就比方说在 layout 用了 Helmet,然后在 page 里又用了一次 Helmet

Helmet 不能嵌套使用,如果平级的两个 Component 都用了 Helmet 会合并结果,如有相同的元素后者会覆盖前者:https://github.com/nfl/react-helmet#example

@mergify mergify bot added waiting-opened-48h PR will be merged by bot after it's opened 48h and removed waiting-opened-48h PR will be merged by bot after it's opened 48h labels Mar 30, 2023
@mergify mergify bot merged commit 0fc222c into bangumi:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L waiting-approval waiting code reviewers to approval PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: 应动态设置页面标题
4 participants