Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pub/Sub Publication #3

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Support Pub/Sub Publication #3

merged 3 commits into from
Mar 2, 2023

Conversation

krak3n
Copy link

@krak3n krak3n commented Mar 1, 2023

What

Adds support for Pub/Sub publication.

stacknowledge
stacknowledge approved these changes Mar 1, 2023
View reviewed changes
Copy link

@stacknowledge stacknowledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aranw
aranw reviewed Mar 1, 2023
View reviewed changes
Copy link

@aranw aranw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes I think mostly looks good though

listener/pubsub_publisher.go Outdated Show resolved Hide resolved
listener/pubsub_publisher.go Outdated Show resolved Hide resolved
krak3n and others added 2 commits March 1, 2023 15:57
@krak3n krak3n merged commit 9aa4b37 into master Mar 2, 2023
@krak3n krak3n deleted the feat/pubsub branch March 2, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranw aranw aranw left review comments

@stacknowledge stacknowledge stacknowledge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krak3n @aranw @stacknowledge