Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Thanos v0.8.0 ; Adding query readiness probe and store readiness + health probes #948

Merged
merged 6 commits into from
Oct 15, 2019

Conversation

levydori
Copy link
Contributor

@levydori levydori commented Oct 10, 2019

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License Apache 2.0

What's in this PR?

Thanos released version 0.8.0 with bug fixes and readiness probes features.
https://thanos.io/changelog/#v0-8-0-https-jackfan.us.kg-thanos-io-thanos-releases-tag-v0-8-0-2019-10-10

I Just changed the default version to v0.8.1 per the bug fixes. Thank to @tarokkk for the comment.

I also changed the default image repository as the Thanos.io is using Quay since v0.7.0 (https://thanos.io/changelog/#v0-7-0-https-jackfan.us.kg-thanos-io-thanos-releases-tag-v0-7-0-2019-09-02)

Why?

Thanos new features - probes and bug fixes

Additional context

N/A

Checklist

  • Error handling code meets the guideline
  • Logging code meets the guideline (TODO)
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@tarokkk tarokkk self-requested a review October 11, 2019 18:03
@tarokkk
Copy link
Contributor

tarokkk commented Oct 11, 2019

There is a querier bug that will be patched soon so I would wait 8.0.1 before releasing new version. thanos-io/thanos#1632 Thanks for the contribution

@tarokkk
Copy link
Contributor

tarokkk commented Oct 14, 2019

The fix is out https://github.com/thanos-io/thanos/releases/tag/v0.8.1 if you change the versions I can make a release.

thanos/README.md Outdated Show resolved Hide resolved
@tarokkk tarokkk requested a review from ahma October 15, 2019 11:20
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @levydori

@tarokkk tarokkk merged commit fe7e46a into banzaicloud:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants