Bump imps to 0.3.12 #65
Conversation
nishantapatil3
requested review from
martonsereg,
waynz0r,
gallotamas,
shanchunyang0919,
tkircsi and
sagikazarmark
as code owners
| @@ -26,7 +26,7 @@ MAIN_PACKAGE ?= ./cmd/controller/ | |||
|
|
|||
| COMMIT_HASH ?= $(shell git rev-parse --short HEAD 2>/dev/null) | |||
| BUILD_DATE ?= $(shell date +%FT%T%z) | |||
| VERSION ?= 0.3.11 | |||
| VERSION ?= 0.3.12 | |||
There was a problem hiding this comment.
This should really come from the git tag IMO.
Created #66 to fix that, so this is not a blocker.
There was a problem hiding this comment.
Yeah this needs to be fixed, thanks for creating the issue. We can come back to fix this later.
go.mod
Outdated
| @@ -10,7 +10,7 @@ require ( | |||
| github.com/aws/aws-sdk-go-v2/credentials v1.10.0 | |||
| github.com/aws/aws-sdk-go-v2/service/ecr v1.1.1 | |||
| github.com/aws/aws-sdk-go-v2/service/sts v1.16.0 | |||
| github.com/banzaicloud/imps/api v0.3.11 | |||
| github.com/banzaicloud/imps/api v0.3.12 | |||
There was a problem hiding this comment.
With the replace in place, this doesn't need updating either.
There was a problem hiding this comment.
Yeah let me fix this in this PR to v0.0.1, would it be okay?
|
BTW @nishantapatil3 it might make sense to merge all those dependabot PRs and tag 0.4.0. Patch releases should really be reserved for ...well, patches. |
Cool. I'll create an issue for resolving all the dependabot PRs. and followup tag for 0.4.0 release #67 |
nishantapatil3
force-pushed
the
SMM-2288-helm
branch
from
02d3e7e to
8cebd2e
Compare
What's in this PR?
Bump helm chart and api version to
0.3.12Why?
Includes fixes for imps and imps-refresher for RedHat certification
Checklist