Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Contribution Guidelines and unit tests #559

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Refactor Contribution Guidelines and unit tests #559

merged 1 commit into from
Sep 1, 2023

Conversation

linghengqian
Copy link
Contributor

@linghengqian linghengqian commented Aug 31, 2023 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style
  • Refactor
  • Doc
  • Other, please describe:

The description of the PR:

  • Refactor Contribution Guidelines and unit tests.
  • Since Dynamic Datasource doesn't involve database-specific processing, I don't think we should use H2Database to emulate a database like MySQL. If we have this need in the future, I tend to use Testcontainer.

Other information:

  • Null.

@linghengqian linghengqian marked this pull request as ready for review August 31, 2023 14:46
@linghengqian
Copy link
Contributor Author

Call @huayanYu to help review.

@huayanYu huayanYu merged commit 08e2f0a into baomidou:master Sep 1, 2023
@linghengqian linghengqian deleted the refactor-unit-tests branch September 1, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linghengqian @huayanYu