🐛 Fix new image upload refresh when URL is the same

We now add a `v` query param containing the timestamp to make sure each newly created file URL is unique
baptisteArno · Nov 21, 2022 · fbd3304 · fbd3304
1 parent 2489318
commit fbd3304
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/apps/builder/src/components/ImageUploadContent/UploadButton.tsx b/apps/builder/src/components/ImageUploadContent/UploadButton.tsx
@@ -31,7 +31,7 @@ export const UploadButton = ({
         },
       ],
     })
-    if (urls.length && urls[0]) onFileUploaded(urls[0])
+    if (urls.length && urls[0]) onFileUploaded(urls[0] + '?v=' + Date.now())
     setIsUploading(false)
   }
 
@@ -43,9 +43,7 @@ export const UploadButton = ({
         id="file-input"
         display="none"
         onChange={handleInputChange}
-        accept={
-          fileType === 'image' ? '.jpg, .jpeg, .png, .svg, .gif' : '.mp3, .wav'
-        }
+        accept={fileType === 'image' ? '.jpg, .jpeg, .png, .gif' : '.mp3, .wav'}
       />
       <Button
         as="label"

diff --git a/apps/builder/src/features/account/components/MyAccountForm/MyAccountForm.tsx b/apps/builder/src/features/account/components/MyAccountForm/MyAccountForm.tsx
@@ -26,10 +26,8 @@ export const MyAccountForm = () => {
     isSaving,
     isOAuthProvider,
   } = useUser()
-  const [reloadParam, setReloadParam] = useState('')
 
   const handleFileUploaded = async (url: string) => {
-    setReloadParam(Date.now().toString())
     updateUser({ image: url })
   }
 
@@ -46,7 +44,7 @@ export const MyAccountForm = () => {
       <HStack spacing={6}>
         <Avatar
           size="lg"
-          src={user?.image ? `${user.image}?${reloadParam}` : undefined}
+          src={user?.image ?? undefined}
           name={user?.name ?? undefined}
         />
         <Stack>